Node property typing #37
Conversation
|
In the [UI Module] function (#24), I would like to add references to subflow templates and instances. Should I base our support for these features on the considerations in this design note? First of all, we have considered supporting these features in the existing implementation. If there is no problem, I would like to issue a PR. |
|
I see from the commit you link to, you are hardcoding the name of Node-RED Dashboard node type into the core of Node-RED - we cannot do that. It is also the exact scenario this Design note is intended to fix.
If the ui module design requires a node's property to reference another node by ID, then yes, this design note is relevant and becomes a prerequisite to the ui module work. This design is still in draft state - it was written to capture the idea for the future, not something I am actively working on. But if this is now needed by the ui_module work, then it needs to be completed and implemented in full. As you can see, there have been no comments on the design I've written - it would be nice to get some feedback to know if this design makes sense and whether it is missing anything. |
I understand. |
|
This Design is complete and initial support implemented via node-red/node-red#2812 There is some follow-up design work about what UI features can now be enhanced with this type-declaration in place. For example, the UI currently displays a select box when a property is declared as being a single type that is a config node. That can now be updated to support the |
A node's
defaultsobject in its HTML definition provides a list of its properties with some metadata associated with them.If a property is intended to be a reference to a configuration node, its entry in the defaults object will include the
typeproperty that identifies the type of config node it should point to.This allows the editor to automatically generate the Config Node select box UI and manage the relationship between the nodes.
This design note explores extending this property to allow for a richer set of relationships between nodes.
It does not (currently) talk about specifying types of node properties more generally - this is only where there is a node property that holds the id (or multiple ids) of other nodes. The editor needs this information when importing/exporting nodes to ensure the references are preserved if ids are changed.
This is a very initial design note just to get these ideas out of my head and somewhere we can discuss them. There is more work to be done around what (if any) UI improvements this could lead to around Config node selection in a node's edit dialog.